⬆️ chore(lint): update ruff to v0.15.14 and fix PLW0717#77
Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.13 → v0.15.14](astral-sh/ruff-pre-commit@v0.15.13...v0.15.14)
Extract helper functions to keep try clauses under the 5-statement limit enforced by ruff 0.15.14.
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff v0.15.14 introduces the
PLW0717rule which flags try clauses exceeding 5 statements. The pre-commit autoupdate bumped ruff and immediately broke CI because four try blocks in the codebase exceeded this threshold.🔧 Each violation is resolved by extracting the try-body logic into focused helper functions:
_is_executablein_discovery.py,_resolve_tk_lib/_query_tk_libraryin_py_info.py,_resolve_exein_pep514.py, andpush_release/finalize_releasein the release script. The refactoring preserves identical runtime behavior while making each try block trivially short.Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>